Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ratelimit): Add metrics rate limit #11538

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat(ratelimit): Add metrics rate limit #11538

merged 2 commits into from
Apr 11, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 10, 2024

closes #11336

on v7: #11505 #11506

@s1gr1d s1gr1d requested review from AbhiPrasad, lforst and Lms24 and removed request for AbhiPrasad, lforst and Lms24 April 10, 2024 14:37
@s1gr1d s1gr1d enabled auto-merge (squash) April 10, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.13 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing) 31.85 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) 67.04 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.63 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.86 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.75 KB (+0.04% 🔺)
@sentry/browser (incl. Feedback) 35.68 KB (+0.09% 🔺)
@sentry/browser (incl. Feedback, Feedback Modal) 35.69 KB (+0.09% 🔺)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 35.7 KB (+0.09% 🔺)
@sentry/browser (incl. sendFeedback) 26.93 KB (+0.11% 🔺)
@sentry/react 24.81 KB (+0.13% 🔺)
@sentry/react (incl. Tracing) 34.76 KB (+0.09% 🔺)
@sentry/vue 25.68 KB (+0.14% 🔺)
@sentry/vue (incl. Tracing) 33.57 KB (+0.1% 🔺)
@sentry/svelte 22.26 KB (+0.15% 🔺)
CDN Bundle 24.25 KB (+0.15% 🔺)
CDN Bundle (incl. Tracing) 32.87 KB (+0.13% 🔺)
CDN Bundle (incl. Tracing, Replay) 66.53 KB (+0.05% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 80.59 KB (+0.04% 🔺)
CDN Bundle - uncompressed 72.15 KB (+0.1% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 98.47 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.86 KB (+0.04% 🔺)
@sentry/nextjs (client) 34.01 KB (+0.12% 🔺)
@sentry/sveltekit (client) 32.37 KB (+0.12% 🔺)
@sentry/node 120.19 KB (+0.03% 🔺)

@s1gr1d s1gr1d force-pushed the sig-metrics-rate-limit-v8 branch from a267b8f to bc7be91 Compare April 11, 2024 11:53
@s1gr1d s1gr1d requested a review from mydea April 11, 2024 11:53
@s1gr1d s1gr1d merged commit 3a1f028 into develop Apr 11, 2024
96 checks passed
@s1gr1d s1gr1d deleted the sig-metrics-rate-limit-v8 branch April 11, 2024 12:21
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@s1gr1d @cadesalaberry
feat(ratelimit): Add metrics rate limit (getsentry#11538)
58326cb 
closes getsentry#11336

on v7: getsentry#11505
getsentry#11506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics Rate Limits
2 participants
@s1gr1d @AbhiPrasad